Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:55

Kjetil Barvik [off-list ref] writes:
Johannes Schindelin [off-list ref] writes:
<snipp>
quoted
My question was more: why do you do additional work and put a git diff 
--raw between the commit message and the diffstat when that information is 
in the patch already?
 Ok, I see.  I (re)used the 'git format-patch' command from previous
 run, and this time it was (without the line-breaks):

    git format-patch  --stat  --patch-with-raw -1 --signoff -M -C
       --summary --full-index --subject-prefix="PATCH"
       --output-directory ../diff_lib_c_symcache_cleanup_v1/
Please drop --patch-with-raw and --full-index.  They are distracting.

I do not think using --subject-prefix=PATCH to repeat what is default adds
any value either.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help