Re: [PATCH (topgit) 1/2] Implement setup_pager just like in git

On Thu, Jan 08, 2009 at 03:06:50PM +1300, martin f krafft wrote:

also sprach Kirill Smelkov [off-list ref] [2009.01.08.1100 +1300]:

quoted

quoted

So I suppose you could use

  ${GIT_PAGER-${PAGER-less}}

or similar.

Good eyes, thanks!

I'll rework it.

I am not 100% on this, but I think nested {}'s are a bashism.

It seems to be ok:

kirr@roro3:~$ dash 
$ unset GIT_PAGER
$ unset PAGER
$ echo ${GIT_PAGER-${PAGER-less}}
less
$ PAGER=more
$ echo ${GIT_PAGER-${PAGER-less}}
more
$ GIT_PAGER=''
$ echo ${GIT_PAGER-${PAGER-less}}

$ GIT_PAGER=/bin/cat
$ echo ${GIT_PAGER-${PAGER-less}}
/bin/cat

quoted

On Wed, Jan 07, 2009 at 03:24:02PM +0100, Bert Wesarg wrote:

quoted

On Wed, Jan 7, 2009 at 12:27, Kirill Smelkov [off-list ref] wrote:

quoted

Martin, thanks for your review.
+       # atexit(close(1); wait pager)
+       trap "exec >&-; rm "$_pager_fifo"; rmdir "$_pager_fifo_dir"; wait" EXIT

I think you need to escape the double quotes.

Good eyes -- corrected and thanks!

You could also just use single quotes inside the double quotes.

Thanks for the tip - I'll keep it in mind. Or is it the preferred way?


Thanks,
Kirill