Thread (17 messages) flat view 17 messages, 5 authors, 2016-06-15

Re: [PATCH 3/3] unpack-trees: remove redundant path search in verify_absent

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:52

Clemens Buchacher [off-list ref] writes:
Since the only caller, verify_absent, relies on the fact that o->pos
points to the next index entry anyways, there is no need to recompute
its position.
I suspect that the original reasoning of this behaviour might have been in
anticipation of other callers, but I agree with your reasoning especially
because I do not think of a good reason to want to receive the number of
entries to skip as the return value and not have o->pos pointing at the
right place.

Thanks, queued.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help