Re: [RFC/PATCH] git-web--browse: don't add start as candidate on Ubuntu

Le jeudi 1 janvier 2009, Ramsay Jones a écrit :

Signed-off-by: Ramsay Jones <redacted>
---

Hi *,

When upgrading to v1.6.1, I noticed that the html help had stopped
working on Linux (Ububtu), viz:

    $ git help -w tag
    start: Need to be root

So, after squinting at git-web--browse.sh, I tried a few things:

    $ ls /bin/start
    ls: /bin/start: No such file or directory
    $ test -n /bin/start; echo $?
    0
    $ which start
    /sbin/start
    $ start fred
    start: Need to be root
    $ ls -l /sbin/start
    lrwxrwxrwx 1 root root 7 2007-06-24 19:45 /sbin/start -> initctl*

So, it would seem that /sbin/start is part of upstart, which would
explain the "Need to be root" ;-)

    $ test -x /bin/start; echo $?
    1
    $

So, the patch below fixes the issue for me, but as I don't have MinGW
installed, I can't test this fix works there.

Does anybody else see this issue and can someone test the patch?

Petr, as you added support for using /bin/start on MinGW, could you test?

Thanks,
Christian.