Re: [PATCH] gitweb: Handle actions with no project in evaluate_path_info
From: Jakub Narebski <hidden>
Date: 2016-06-15 22:45:51
On Sun, 28 Dec 2008, Devin Doucette wrote:
The action would not be set if no valid project was found in path_info. Removing the return if the project was not specified fixes the project_index and opml actions when using path_info.
Thanks for catching this. Truth to be told we parse action parameter in path_info only since d8c2882 (gitweb: parse project/action/hash_base:filename PATH_INFO) by Giuseppe Bilotta (CC-ed; I think he is correct person to give Ack for this patch). Earlier only "default" actions could be expressed using only path_info, and project-less 'opml' and 'project_index' actions are not default actions for projectless URL, so there was no such problem then.
quoted hunk ↗ jump to hunk
Signed-off-by: Devin Doucette <redacted> --- gitweb/gitweb.perl | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 8f574c7..b6a8ea9 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -552,8 +552,7 @@ sub evaluate_path_info { while ($project && !check_head_link("$projectroot/$project")) { $project =~ s,/*[^/]*$,,; } - return unless $project; - $input_params{'project'} = $project; + $input_params{'project'} = $project if $project; # do not change any parameters if an action is given using the query string return if $input_params{'action'};-- 1.6.1.rc4
-- Jakub Narebski Poland