Re: [PATCH 2/2] grep: grep cache entries if they are "assume unchanged"

Nguyễn Thái Ngọc Duy  [off-list ref] writes:

... External grep case has not been fixed yet. But given that
on the platform that CE_VALID bit may be used like Windows, external
grep is not available anyway, I would wait for people to raise their
hands before touching it.

My gut feeling is that it would suffice to always use the internal grep if
there is any index entry with CE_VALID set.  Having the bit is an unusual
case.

Also I am guessing that your above statement that users on Windows would
be the ones who want CE_VALID implies that CE_VALID is for platforms where
file operations are slow.  If that is really the case, the internal grep
might even have performance advantage over external grep.

No, I haven't benched the internal grep recently.