Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: fatal output from git-show really wants a terminal

From: Jeff King <hidden>
Date: 2016-06-15 22:45:46

On Mon, Dec 15, 2008 at 12:15:38AM -0800, Junio C Hamano wrote:
I haven't heard anything more about this, but if you were indeed
discussing the change made by 61b8050, I think the fix should just be like
this.
[...]
-	dup2(pager_process.in, 2);
+	if (isatty(2))
+		dup2(pager_process.in, 2);
I can't speak for the original poster, but I do think this behavior
should be less surprising to users who perform the one particular
redirection (and in the other 99% of cases, should behave exactly the
same). So I think it's a positive change.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help