Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH try 2] gitweb: Add option to put a trailing slash on pathinfo-style project URLs

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:46

Jakub Narebski [off-list ref] writes:
quoted
+	# If you want a trailing slash on the project path (because, for
+	# example, you have a real directory at that URL and are using
+	# some rewrite magic to invoke gitweb), then set:
+	# $feature{'pathinfo'}{'default'} = [1, 1];
+
Are any disadvantages to having it always enabled?
Good question.
quoted
+	my @use_pathinfo = gitweb_get_feature('pathinfo');
Why not name those variables for better readability?

+       my ($use_pathinfo, $trailing_slash) = gitweb_get_feature('pathinfo');
Good suggestion.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help