Thread (6 messages) 6 messages, 3 authors, 2016-06-15

[PATCH] autodetect number of CPUs by default when using threads

flat view
STALE3770d

From: Nicolas Pitre <hidden>
Date: 2016-06-15 22:45:45
Subsystem: the rest · Maintainer: Linus Torvalds

... and display the actual number of threads used when locally 
repacking.  A remote server still won't tell you how many threads it 
uses during a fetch though.

Signed-off-by: Nicolas Pitre <redacted>
---

I've spent quite a while wondering why repacking in one repo was faster 
than repacking in a clone of that repo on the same machine.  So let's 
display how many threads are actually used.

We have comprehensive test in Makefile to determine if threads are 
available, just to not use them by default.  I think that code has 
proven itself for long enough now not to let people benefit from it.
diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
index cedef52..619e597 100644
--- a/builtin-pack-objects.c
+++ b/builtin-pack-objects.c
@@ -78,7 +78,7 @@ static int progress = 1;
 static int window = 10;
 static uint32_t pack_size_limit, pack_size_limit_cfg;
 static int depth = 50;
-static int delta_search_threads = 1;
+static int delta_search_threads;
 static int pack_to_stdout;
 static int num_preferred_base;
 static struct progress *progress_state;
@@ -1612,6 +1612,9 @@ static void ll_find_deltas(struct object_entry **list, unsigned list_size,
 		find_deltas(list, &list_size, window, depth, processed);
 		return;
 	}
+	if (progress > pack_to_stdout)
+		fprintf(stderr, "Delta compression using %d threads.\n",
+				delta_search_threads);
 
 	/* Partition the work amongst work threads. */
 	for (i = 0; i < delta_search_threads; i++) {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help