Re: git fsck segmentation fault

mkoegler@auto.tuwien.ac.at (Martin Koegler) writes:

fsck_walk has been designed to call a function on all directly
connected objected. There are callers, which expected this behaviour
(eg. index-pack, mark_used in fsck).

Yes, that is where my "initially expected" comes from.  I was not
complaining or suggesting the behaviour to change.

I was fooled by the word *walk* in the name, which implies an
implementation of walking connectivity fully, with or without an ability
for the callback to tell the machinery when to or not to dig deeper.  It
wouldn't have been confusing if it were named "fsck_step()", which is what
the function is about: performing a single step of digging deeper.