Luben Tuikov [off-list ref] writes:
quoted hunk
--- On Wed, 12/10/08, Jakub Narebski <jnareb@gmail.com> wrote:
quoted
Acked-by: Luben Tuikov <redacted>
Signed-off-by: Jakub Narebski <redacted>
I've always seen "Acked-by:" follows "Signed-off-by:". Junio, has this
changed?
I think the order is supposed to show the order of things happened. Jakub
signs off the patch, you Ack, and I see the patch and append my sign-off.
You saw the exact same patch text, said that looked Ok to you, and Jakub
updated the log message to present the change better and signed off the
whole thing again. You could say that there should be another, original,
sign off by Jakub before your Ack, but I do not think it adds anything of
value.
In any case, the change will be queued to 'pu'. It is great that it is a
trivial change that gives us great performance boost, and I wish all our
patches are like that ;-).