Re: Annotating patches inside diff
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:45:45
Hi, On Wed, 10 Dec 2008, Jakub Narebski wrote:
quoted hunk ↗ jump to hunk
I remember that long time ago on git mailing list there was discussed extending git-apply and friends (including git-am), to be able to ignore lines in patches with selected special prefix, different from '@' for chunks headers, ' ' for context, '+'/'-' for added/deleted lines. IIRC it was chose '|' for this purpose. This way you could annotate patch@@ -4667,7 +4667,6 @@ HTML hash_base => $parent_commit); print "<td class=\"linenr\">"; print $cgi->a({ -href => "$blamed#l$orig_lineno",| moved to <tr> - -id => "l$lineno", -class => "linenr" }, esc_html($lineno)); print "</td>"; Was it accepted or dropped, or is this feature present but not documented?
As I said on IRC, I think that if you are too good in the hiding-comments business, you can just spare the time to write them, 'cause nobody will find them. IOW such a comment needs to go either into the commit message (if it is an important API change), so that people who do not remember discussions on the mailing list still have a chance to find the comment, or between the message and the diffstat (if it is less important). Ciao, Dscho