Re: builtin-add.c patch
From: Alexander Potashev <hidden>
Date: 2016-06-15 22:45:45
Hello, Tim! On 06:38 Wed 10 Dec , daly@axiom-developer.org wrote:
quoted hunk ↗ jump to hunk
A trivial patch to fix a typo -- Tim Dalydiff --git a/builtin-add.c b/builtin-add.c index ea4e771..5f2e68b 100644 --- a/builtin-add.c +++ b/builtin-add.c@@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs) int num_unmatched = 0, i; /* - * Since we are walking the index as if we are warlking the directory, + * Since we are walking the index as if we are walking the directory,
We probably should use subjunctive here: "Since we are walking the index as if we _were_ walking the directory,". Are there any native English speakers? :)
* we have to mark the matched pathspec as seen; otherwise we will * mistakenly think that the user gave a pathspec that did not match * anything. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
It's also better to change the commit message, one should be able to realize from it that the change is a typo fix in comments.