Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [RFCv4 1/3] gitweb: add patch view

From: Giuseppe Bilotta <hidden>
Date: 2016-06-15 22:45:44

On Sun, Dec 7, 2008 at 7:04 AM, Matt Kraai [off-list ref] wrote:
Howdy,

Why do you check $patch_max at the start of git_commitdiff instead of
at the start of hunk which opens git-format-patch?  It seems like it
would be clearer to check it later, at some small loss of efficiency.
Subsequent patches use the check to add a link to the nav bar, so it
reduces code shift from patch to patch 8-)

-- 
Giuseppe "Oblomov" Bilotta
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help