Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 1/8] generate-cmdlist.sh: avoid selecting synopsis at wrong place

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:42

Johannes Schindelin [off-list ref] writes:
On Sun, 30 Nov 2008, Nguyễn Thái Ngọc Duy wrote:
quoted
In "common" man pages there is luckily no "NAME" anywhere except at 
beginning of documents. If there is another "NAME", sed could mis-select 
it and lead to common-cmds.h corruption. So better nail it at beginning 
of line, which would reduce corruption chance.
I have no idea why you put this into the sparse checkout patch series.
That is because a documentation that triggers the misfortune this patch
fixes is introduced in the series.  I actually scratched head myself,
though, and come to think of it, I should have complained that this patch
should state that because it does not look like it has anything do with
the main topic of the series.
As it is, the patch series is _already_ hard to review (as it is large not 
only in term of number of patches, but also individual patch size), 
_especially_ given the fact that there is no clear, precise and short 
description of why/how the sparse checkout is implemented.
Hmm, can you really tell the lack of such description without reading the
series, I have to wonder...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help