Re: [PATCH] mmap implementation for mingw.

On Fri, Nov 21, 2008 at 5:48 AM, Johannes Schindelin
[off-list ref] wrote:

Hi,

[re-Cc:ed j6t]

On Fri, 21 Nov 2008, Vasyl' Vavrychuk wrote:

quoted

[Dscho knows that j6t wrote this:]

quoted

It doesn't pass the test suite, for example t5301-sliding-window.sh
fails.

I will investigate.

Note that I quickly discarded the idea of mmap() on MinGW because at least
in the past, we used to rename files that were mmap()ed.  That is a no-go
with CreateFile().

Hi,

I'm not overly familiar with the windows API, but wouldn't passing
FILE_SHARE_DELETE | FILE_SHARE_READ in the dwShareMode argument of
CreateFile() be enough to allow rename/deletion of the file in
question while it is mapped?

Thanks,

Bryan Donlan