Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] gitweb: fixes to gitweb feature check code

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:40

Jakub Narebski [off-list ref] writes:
Dnia poniedziałek 17. listopada 2008 07:10, Giuseppe Bilotta napisał:
quoted
On Mon, Nov 17, 2008 at 2:02 AM, Jakub Narebski [off-list ref] wrote:
[...]
quoted
quoted
First, you forgot the signoff, but you have addressed that already.


Second, I thought at first that it would be good for the patch to also
simplify %feature hash, using "'default' => 1" instead of current bit
convoluted "'default' => [1]", at the cost of bit more code for
defensive programming.  But now I think that if it is to be done,
it should be put as separate patch.
Is this an ACK? 8-D
I'm sorry. Yes, it is.
Are you sure, even with those unnecessary changes from list context
assignments to scalar ones?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help