Re: [RFC PATCH 0/4] deny push to current branch of non-bare repo
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:37
Jeff King [off-list ref] writes:
The FAQ even says "don't do this until you know what you are doing." So the safety valve is configurable, so that those who know what they are doing can switch it off.
"We are breaking your existing working setup but you can add a new configuration to unbreak it" should not be done lightly. I think as the end result it is a reasonable thing to aim for for this particular feature, but we do need a transition plan patch in between that introduces a step that warns but not forbids. We can ship 1.6.1 with it and then switch the default to forbid in 1.6.3, for example.
Patch 4/4 is the interesting one. 1/4 is a cleanup I saw while fixing tests. 2/4 is a cleanup to prepare for 3/4. And 3/4 fixes a bunch of tests which were inadvertently doing such a push (but didn't care because they didn't look at the working directory).
I wonder if you can use the tests 3/4 touches as the test for your "keep existing setup" configuration variable, pretending that they are old timer's repositories?