Thread (40 messages) flat view 40 messages, 7 authors, 2016-06-15

Re: [PATCH 1/3] packed_git: convert pack_local flag into generic bit mask

From: Brandon Casey <hidden>
Date: 2016-06-15 22:45:34

Shawn O. Pearce wrote:
drafnel@gmail.com wrote:
quoted
diff --git a/cache.h b/cache.h
index b0edbf9..0cb9350 100644
--- a/cache.h
+++ b/cache.h
@@ -679,12 +679,15 @@ extern struct packed_git {
 	int index_version;
 	time_t mtime;
 	int pack_fd;
-	int pack_local;
+	unsigned int flags;
Hmm, isn't this a smaller change to make?
heh, well if you want to do it the "easy" way. :)

For some reason I've never used this bit field mechanism, but
I agree it is more readable and simpler, and you can't argue
with that.

-brandon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help