Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/3] Fix error in diff_filepair::status documentation.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:34

Yann Dirson [off-list ref] writes:
quoted hunk
Signed-off-by: Yann Dirson <redacted>
---

 diffcore.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/diffcore.h b/diffcore.h
index 713cca7..05d0898 100644
--- a/diffcore.h
+++ b/diffcore.h
@@ -62,7 +62,7 @@ struct diff_filepair {
 	struct diff_filespec *one;
 	struct diff_filespec *two;
 	unsigned short int score;
-	char status; /* M C R N D U (see Documentation/diff-format.txt) */
+	char status; /* M C R A D U etc. (see DIFF_STATUS_* in diff.h) */
I think you spotted the right bug and fixed it in a wrong way.  The status
letters are user visible, and "git grep status Documentation/*diff*"
mention it in handful places without listing its repertoire, which _is_
the bug.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help