Thread (11 messages) flat view 11 messages, 8 authors, 2016-06-15

Re: [PATCH] Avoid using non-portable `echo -n` in tests.

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:45:33

Brian Gernhardt [off-list ref] wrote:
Not all /bin/sh have a builtin echo that recognizes -n.  Using printf
is far more portable.
 
quoted hunk ↗ jump to hunk
diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh
index c1850d2..f6a2dbd 100755
--- a/t/t9400-git-cvsserver-server.sh
+++ b/t/t9400-git-cvsserver-server.sh
@@ -424,7 +424,7 @@ cd "$WORKDIR"
 test_expect_success 'cvs update (-p)' '
     touch really-empty &&
     echo Line 1 > no-lf &&
-    echo -n Line 2 >> no-lf &&
+    printf Line 2 >> no-lf &&
That needs to be:

	printf 'Line 2'

to have the same result.  Fortunately I don't think it matters
in this test, but it does read odd.

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help