Thread (6 messages) 6 messages, 3 authors, 2016-06-15

Re: [RFC PATCH v2] fetch-pack: log(n)-transmission find_common()

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:32

Possibly related (same subject, not in this thread)

Nanako Shiraishi [off-list ref] writes:
Quoting Thomas Rast [off-list ref]:
quoted
Replaces the existing simple history search with a more sophisticated
algorithm:

1) Walk history with exponentially increasing stride lengths; i.e.,
   send the 1st commit, then the 2nd after that, then the 4th after
   that, and so on.

2) Bisect the resulting intervals.
Junio, may I ask what the status of this patch is? I see Nicolas responded and said "I gave this a quick try". Wasn't it a good enough review?
I took the "quick try" more about "first feel in performance" and not
"code review concentrating on correctness and trying to catch mistakes".

I like what the patch tries to solve, and the approach it takes to solve
it.  I haven't had a chance to have a block of time for me to concentrate
on this patch to assess where it could go wrong yet.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help