Re: [PATCH] fix guilt-pop and push to fail if no relevant patches

On Fri, 17 Oct 2008, Josef 'Jeff' Sipek wrote:

On Fri, Oct 17, 2008 at 07:37:33AM -0400, Scott Moser wrote:

quoted

Jeff,
   Did you not like the patch below for some reason ?

I don't remember my train of thought, but I ended up making a simpler patch
to address the push-pushing-more-than-it-should bug. I completely missed the
part about the exit codes.

good enough. I hadn't pulled in a while and didn't realize you'd made a
change.  I never actually saw a problem with "pushing too much" , but
only in the exit codes.

quoted

quoted

diff --git a/guilt-push b/guilt-push
index 018f9ac..48f886b 100755
--- a/guilt-push
+++ b/guilt-push

[snipped long diff]

With my fix, this should be a 2-liner :)

for what its worth, the patch i sent only added a couple lines.  It
really just changed indentation.  So, the patch was long, only 2 new
lines that did anything.

anyway... I'm happy if you make it exit failure.

Thanks,