Re: [PATCH] git-svn: call 'fatal' correctly in set-tree
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:28
Luc Heinrich [off-list ref] writes:
quoted hunk
When doing a set-tree and there is no revision to commit to, the following unrelated error message is displayed: "Undefined subroutine &Git::SVN::fatal called at /opt/local/libexec/git-core/git-svn line 2575." The following patch fixes the problem and allows the real error message to be shown. Signed-off-by: Luc Heinrich <redacted> --- git-svn.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/git-svn.perl b/git-svn.perl index 80a5728..7609a83 100755 --- a/git-svn.perl +++ b/git-svn.perl@@ -2591,7 +2591,7 @@ sub set_tree { my ($self, $tree) = (shift, shift); my $log_entry = ::get_commit_entry($tree); unless ($self->{last_rev}) { - fatal("Must have an existing revision to commit"); + ::fatal("Must have an existing revision to commit"); } my %ed_opts = ( r => $self->{last_rev}, log => $log_entry->{log},
Shouldn't the same change be done for the fatal call from apply_diff in SVN::Git::Editor package?