Thread (1 message) 1 message, 1 author, 2016-06-15

Re: Adding Reviewed-by/Tested-by tags to other peoples commits

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:28

Jeff King [off-list ref] writes:
On Sat, Oct 11, 2008 at 07:37:04AM +0100, Alex Bennee wrote:
quoted
I've just tested/reviewed a patch of someone elses and I want to
forward it on the appropriate mailing list. I gather for Linux you
just add the appropriate tags to the commit. Does git offer a shortcut
for doing this or do you have to do a reset HEAD^ and re-commit with a
copy&pasted and modified commit message?
Try "git commit --amend" to edit the commit message. There's no
automatic way of adding acked-by or tested-by tags with git; most people
who do those things often would probably configure their editor to make
it easier.
These Distimmed-by: fields are cumulative in nature, so once recorded in a
commit log message you cannot add new ones without amending, which means
you cannot exchange such commits by pushing or pulling but by forwarding
patches via e-mails.  I thought people added these in their MUAs.  IOW, I
share your "would probably" with s/editor/MUA/.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help