Re: [PATCHv2] gitweb: refactor input parameters parse/validation

On Fri, Oct 10, 2008 at 5:01 PM, Shawn O. Pearce [off-list ref] wrote:

Giuseppe Bilotta [off-list ref] wrote:

quoted

+sub validate_action {
+     my $input = shift || return undef;
+     return undef unless exists $actions{$action};
+     return $action;
+}

Shouldn't $action here be $input?

Urgh. Yes, yes it should. Good catch. Should I resend?


-- 
Giuseppe "Oblomov" Bilotta