Re: [QGit bug] git user settings not retrieved when launched for Windows explorer

On Tue, Oct 7, 2008 at 2:31 PM, Abdelrazak Younes [off-list ref] wrote:

No, 'git config user.name' works fine in any directory, even on the naked
Windows console (I mean without msys bash). So that must be something else.
I've traced it down to
MyProcess::on_finished().

   isErrorExit =   (exitStatus != QProcess::NormalExit)
                || (exitCode != 0 && isWinShell)
                || !errorDesc.isEmpty()
                ||  canceling;

At this point we have:
exitStatus = NormalExit
exitCode = 1
isWinShell = false
errorDesc.isEmpty() returns true
canceling = false

Which gives 'isErrorExit = false'. I wonder if the isWinShell test is
correct?

Hi Abdel,

I would think it is correct to return isErrorExit == false

The problem is that it seems git config return empty data if run from
outside git directory...isn't it ?


Marco