Re: [PATCH] rebase --no-verify
From: Stephan Beyer <hidden>
Date: 2016-06-15 22:45:27
Hi, Shawn O. Pearce wrote:
quoted
It probably is better to fix "rebase -i" to share more code with the main "rebase" script to avoid duplicated run-pre-rebase-hook function, but it is beyond what I can do right now. Perhaps people more smart and beautiful than me can help (^_^;)True. But its already a mess. git-sequencer is probably the right approach to merge it all together.
Hmm, I don't think I like the pre-rebase hook in sequencer. The user scripts (git-rebase--interactive.sh and git-rebase.sh) should run them; that's ok. I think, for the moment it is ok to have the code duplicated. After sequencer has merged into master[1], I will probably take a look at merging git-rebase.sh and git-rebase--interactive.sh if somebody else is interested in it and if there is a good way to achieve that. Regards, Stephan Footnotes: 1. For the *very* interested ones of you, http://repo.or.cz/w/git/sbeyer.git is the way to go. seq-builtin-dev is the active development branch and git's master is frequently merged into it. seq-builtin-rfc^ is an approach to possible patchsets (for review). -- Stephan Beyer [off-list ref], PGP 0x6EDDD207FCC5040F