Re: [PATCH] git-cvsexportcommit: handle file status reported out of order (was Re: [PATCH] Make git-cvsexportcommit "status" each file in turn)

Hi,

On Thu, 2 Oct 2008, Nick Woolley wrote:

Johannes Schindelin wrote:

quoted

Also, given the fact that you actually verified that it was fixed in 
1.6.0, what exactly is your proposed course of action?  Revert the fix 
in 1.6.0 and apply your patch?  Apply your patch to 1.5.6.5, cracking 
a release 1.5.6.6 with your patch?

Neither. At the moment, I can only offer what I have: a patch for 
1.5.6.5, representing an idea that may contribute something small to 
1.6.0 (using information from CVS on STDERR). It should be simple to 
adapt if it's useful, if not please ignore it.

Since you did not use the preferred form of a patch, you also do not have 
a commit message describing the idea of your patch.  It is a bit hard to 
find out the intention from reading the source, and I am not motivated 
enough to find out, given that it is fixed with the commit I referred you 
to.

To save you time: the idea of the commit I referred you to is not exactly 
to use the basename, but the trimmed names.  Now only sets of unique names 
(where it is also checked that a name could not be mistaken for another, 
deleted file) are passed to cvs status.

BTW next time you search for some fix in Git's source code, you might want 
to use either "git log -- <file>" or "git bisect" to find the commit in 
question.

Hth,
Dscho