Thread (13 messages) flat view 13 messages, 3 authors, 2016-06-15

Re: [EGIT PATCH 3/8] Dispose of allocated colors on finalize()

From: Robin Rosenberg <hidden>
Date: 2016-06-15 22:45:25

onsdagen den 1 oktober 2008 16.37.18 skrev Shawn O. Pearce:
Robin Rosenberg [off-list ref] wrote:
[..]
I think this is wrong.  Any color that we get from
[...]
What was the rationale for disposing of these resources?  Did you
identify that this is a resource leak somewhere?  Because I'd like
to make sure I actually understand the SWT resource model better
so I don't commit mistakes in the future.
I read the Color javadoc, but not the getSystemColor one. You are right, drop this patch
and the "dispose" hunk in the next patch (which was also a

-- robin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help