Re: [PATCH] tests: grep portability fixes
From: Andreas Ericsson <hidden>
Date: 2016-06-15 22:45:25
Jeff King wrote:
quoted hunk ↗ jump to hunk
We try to avoid using the "-q" or "-e" options, as they are largely useless, as explained in aadbe44f. There is one exception for "-e" here, which is in t7701 used to produce an "or" of patterns. This can be rewritten as an egrep pattern. This patch also removes use of "grep -F" in favor of the more widely available "fgrep". Signed-off-by: Jeff King <redacted> ---diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh index 4db4ac4..cb14425 100755 --- a/t/t0002-gitfile.sh +++ b/t/t0002-gitfile.sh@@ -32,7 +32,7 @@ test_expect_success 'bad setup: invalid .git file format' ' echo "git rev-parse accepted an invalid .git file" false fi && - if ! grep -qe "Invalid gitfile format" .err + if ! grep "Invalid gitfile format" .err
Doesn't output need to be redirected when you drop '-q'? Other than that, this looks good after a quick scan. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231