Re: [PATCH] Builtin-commit: show on which branch a commit was added

On Tue, Sep 30, 2008 at 08:37:00AM +0200, Wincent Colaiuta wrote:

quoted

"commit" is just noise.

Excellent point on the noise. Independently of whether the branch info  
gets added the word "commit" should probably be dropped.

The branch info has already been added, if you count it being in next
(in the form of "on $branch: ").

As far as long-line-wrapping goes, I don't really think this is a problem 
for Git to solve (by truncation or any other means); it's more of a user 
behaviour thing where one would hope that users would get into the habit 
of using concise subject lines and branch names.

How concise must we be? I wrap my commit messages at 60 characters,
which I consider quite conservative. But

  Created commit abcd1234 on jk/my-topic-branch:

takes up over half of an 80-column terminal. Is that a long branch name?
Browsing "git log --grep=Merge.branch --pretty=format:%s origin/next"
suggests it's not terribly out of line (at least by Junio's standards).

Dropping "commit " will help some. But given how much width is still
used, and the fact that this message is really just to say "yes, I
confirm that we just created the commit you asked for", I think
truncating (with dots) to keep it within 80 characters is reasonable.

-Peff