Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH v2] maint: check return of split_cmdline to avoid bad config strings

From: Miklos Vajna <hidden>
Date: 2016-06-15 22:45:24

On Wed, Sep 24, 2008 at 10:50:29AM -0400, Deskin Miller [off-list ref] wrote:
As the testcase demonstrates, it's possible for split_cmdline to return -1 and
deallocate any memory it's allocated, if the config string is missing an end
quote.  In both the cases below, which are the only calling sites, the return
isn't checked, and using the pointer causes a pretty immediate segfault.

Signed-off-by: Deskin Miller <redacted>
Acked-by: Miklos Vajna <redacted>

Thanks.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help