Re: [PATCH (GIT-GUI,GITK) 0/8] Encoding support in GUI

On Thu, Sep 18, 2008 at 1:45 AM, Paul Mackerras [off-list ref] wrote:

Alexander Gavrilov writes:

quoted

Currently GUI tools don't provide any support for
viewing files that contain non-ASCII characters.

Well, that's just not true, at least as far as gitk is concerned.

Somehow being able to show files in the system encoding is not good
enough for a tool that is supposed to be used for cross-platform
projects. It is only marginally better than always using ISO-8859-1,
as git-gui, in effect, did.

If you feel there are deficiencies in how gitk handles encodings (and
I'm quite willing to believe there are, since ASCII is sufficient for
my needs), then please give us a detailed explanation of what you
would like it to do or specifically what is wrong with what it does at
the moment.  I'd like to see several paragraphs, not just the one or
two sentences you have put in the descriptions for patches 6-8.

I did not combine this set of patches into a single group without a
reason. This is a policy decision that spans the boundary of
individual tools, although it is initially implemented and documented
on the git-gui side. The gitk commits simply bring back changes to
code originally copied from gitk, tie in new logic that supports
per-file encoding, and fix some obvious breakage (of course, I can
write longer descriptions for them). By the way, patch 4 will apply to
gitk, if you replace 'lib/encoding.tcl' with 'gitk', and specify -C2.

P.S. All changes are build on top of these two commits:
http://repo.or.cz/w/git-gui.git?a=log;h=refs/heads/pu

Alexander