Thread (28 messages) flat view 28 messages, 8 authors, 2016-06-15

Re: [PATCH FYI] t9700/test.pl: backwards compatibility improvements

From: Brandon Casey <hidden>
Date: 2016-06-15 22:45:21

Tom G. Christensen wrote:
Brandon Casey wrote:
quoted
Some versions of perl complain when 'STDERR' is used as the third
argument
in the 3-argument form of open(). Convert to the 2-argument form which is
described for duping STDERR in my second edition camel book.

The object oriented version of File::Temp is a rather new incarnation it
seems. The File::Temp man page for v5.8.0 says "(NOT YET IMPLEMENTED)" in
the 'Objects' section. These can be converted to use
File::Temp::tempfile().

Signed-off-by: Brandon Casey <redacted>
Tested-by: Tom G. Christensen <redacted>

Without this patch the testsuite will fail with perl 5.8.0:
t9700$ ./test.pl
ok 1 - use Git;
Bareword "STDERR" not allowed while "strict subs" in use at ./test.pl
line 41.
Execution of ./test.pl aborted due to compilation errors.
1..1
# Looks like your test died just after 1.


Could we please get this patch in?
Junio had asked me to follow up on that patch at a later time, so
thanks for prodding.

Here is an alternative which _removes_ the File::Temp requirement.

-brandon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help