Re: [PATCH 10/16] grep: skip files that have not been checked out

Duy Nguyen wrote:

On 09/15/2008 "Jakub Narebski" [off-list ref] wrote:

quoted

Nguyễn Thái Ngọc Duy [off-list ref] writes:

quoted

Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 builtin-grep.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

No changes to Documentation/git-grep.txt?

No, "git grep" should only grep files in working directories. In
narrow checkout mode, some files may be missing but current "git grep"
does not know about that, hence this fix.  

Perhaps that should be stated explicitly, that git-grep searches only
[intentionally] checked-out files when searching working directory,
and only files without no-checkout bit set when searching index with
"git grep --cached".

P.S. I think it should be [--cached|<tree>...] in git-grep synopsis,
and not [--cached] ... [<tree>...], but that is unrelated thing, and
doesn't matter to you.
-- 
Jakub Narebski
Poland