Abhijit Menon-Sen [off-list ref] writes:
At 2008-09-08 03:27:59 -0700, normalperson@yhbt.net wrote:
quoted
They'll show up as false positives when grepping for "git-"
Fine, you're the maintainer, but for the record, I think this change is
dreadful. Changing all "git-svn blah" commands to "git svn blah" is one
thing, but obfuscating tests on the off-chance that someone might grep
for "git-" seems entirely wrong.
I think the value of this first one is not "on the off-chance" thing, but
the presense of this change makes it far easier to eyeball the result of
applying the second, large-ish patch.
If I were doing this as a series, I would probably have followed them up
with a patch that reverts the token replacement this first one does as the
final patch in the series, but I also think leaving this first patch as-is
is fine.