Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] Use GIT_COMMITTER_IDENT instead of hardcoded values in import-tars.perl

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:45:19

Possibly related (same subject, not in this thread)

Hi,

On Sun, 7 Sep 2008, Mike Hommey wrote:
-my $committer_name = 'T Ar Creator';
-my $committer_email = 'tar@example.com';
+chomp(my $committer_ident = `git var GIT_COMMITTER_IDENT`);
+die 'You need to set user name and email'
+	unless ($committer_ident =~ s/(.+ <[^>]+>).*/\1/);
I have at least one script that will be broken by this change in behavior.

To me, the issue is just like git-cvsimport, which sets the committer not 
to the actual committer, so that two people can end up with identical 
commit names, even if they cvsimported independently.  I'd like the same 
behavior for import-tars.  I actually use it that way.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help