Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH] t/t91XX-svn: start removing use of "git-" from these tests

From: Eric Wong <hidden>
Date: 2016-06-15 22:45:19

Abhijit Menon-Sen [off-list ref] wrote:
At 2008-09-08 19:02:05 +0900, nanako3@lavabit.com wrote:
quoted
This first step replaces literal strings "remotes/git-svn" and
"git-svn-id" by introducing $remotes_git_svn and $git_svn_id
constants defined as shell variables.
I'm sorry, but... why? I don't see the point at all. These are not even
commands; and, as someone who was just reading the svn tests, the change
certainly doesn't make them *easier* to follow.
They'll show up as false positives when grepping for "git-"

The commit message should've mentioned that, though (assuming I'm
reading Nanako's mind correctly :)

Nanako: I'm fine with the patches, too sleepy and tired to actually test
them, though.

-- 
Eric Wong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help