Re: [cgit PATCH] use Host: header to generate cgit_hosturl

On Tue, Sep 2, 2008 at 1:30 AM, Eric Wong [off-list ref] wrote:

Lars Hjemli [off-list ref] wrote:

quoted

On Tue, Sep 2, 2008 at 1:07 AM, Eric Wong [off-list ref] wrote:

quoted

Lars Hjemli [off-list ref] wrote:

quoted

On Mon, Sep 1, 2008 at 8:30 AM, Eric Wong [off-list ref] wrote:

quoted

So use the "Host" header if it is available and fall back to
SERVER_NAME/SERVER_PORT for some clients that don't set
HTTP_HOST.

Maybe it would be better to use a new cgitrc parameter as fallback if
the client doesn't provide the "Host" header?

That sounds a bit hackish to me since HTTP_HOST, SERVER_NAME and
SERVER_PORT are all standardized.  Anyhow, it's your call :)

I just figured that since SERVER_NAME/SERVER_PORT doesn't work in a
setup like the one you described, clients which doesn't provide the
"Host" header would never get a correct url. A default value for the
"Host" header in cgitrc would work around this issue.

Actually, in my situation, the proxy server will unconditionally set a
Host: header before sending the request to the lighttpd backend.  Header
rewriting/injection is a common feature in HTTP aware proxies.

Ok, so if we assume that the "Host" header is only missing if the
client didn't specify it and there's no proxy involved, using
SERVER_NAME/SERVER_PORT as a fallback should be ok.

Thanks for the patch and explanation.

--
lh