Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15
DORMANTno replies

[PATCH] Allow 'git cmd -h' outside of repository

From: SZEDER Gábor <hidden>
Date: 2016-06-15 22:45:15
Subsystem: the rest · Maintainer: Linus Torvalds

Printing usage strings of git commands should obviously not depend on
the command being run inside a git repository.  However, in case of a
command requiring a repository, the command line options are parsed only
after it is ensured that the command was started inside a repository,
resulting in a 'fatal: Not a git repository' if 'git cmd -h' wasn't
executed inside a repository.

To get around this issue, we will check early for the presence of '-h'
option, and skip ensuring that the command is run inside a repository.

Signed-off-by: SZEDER Gábor <redacted>
---
 git.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/git.c b/git.c
index 37b1d76..af53472 100644
--- a/git.c
+++ b/git.c
@@ -380,6 +380,10 @@ static void handle_internal_command(int argc, const char **argv)
 		struct cmd_struct *p = commands+i;
 		if (strcmp(p->cmd, cmd))
 			continue;
+		/* Don't require repository if only usage string is requested */
+		if (argc > 1 && !strcmp(argv[1], "-h")) {
+			p->option = 0;
+		}
 		exit(run_command(p, argc, argv));
 	}
 }
-- 
1.6.0.1.133.g10dd.dirty
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help