Re: [PATCH] be paranoid about closed stdin/stdout/stderr
From: Paolo Bonzini <hidden>
Date: 2016-06-15 22:45:14
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] be paranoid about closed stdin/stdout/stderr · Paolo Bonzini <hidden>
- 2016-06-15 · Re: [PATCH] be paranoid about closed stdin/stdout/stderr · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] be paranoid about closed stdin/stdout/stderr · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] be paranoid about closed stdin/stdout/stderr · Stephen R. van den Berg <hidden>
- 2016-06-15 · Re: [PATCH] be paranoid about closed stdin/stdout/stderr · Karl Chen <hidden>
quoted
But it's harmless to have both.Considering the fact that daemon authors might not get pointed at their mistakes as soon as possible, it is harmful to try and hide those facts.
Agree. OTOH what about opening fd's 0/1/2 to /dev/null only in git-shell.c, now that it's not a builtin anymore? Maybe it does not fix Karl's use case, but it seems sensible to me. Paolo