Re: [PATCH] git diff/diff-index/diff-files: call setup_work_tree()
From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:45:13
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] git diff/diff-index/diff-files: call setup_work_tree() · Junio C Hamano <hidden>
On 8/25/08, Miklos Vajna [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/builtin-diff.c b/builtin-diff.c index 7ffea97..57da6ed 100644--- a/builtin-diff.c +++ b/builtin-diff.c@@ -279,6 +279,7 @@ int cmd_diff(int argc, const char **argv, const char *prefix) diff_no_index(&rev, argc, argv, nongit, prefix); /* Otherwise, we are doing the usual "git" diff */ + setup_work_tree(); rev.diffopt.skip_stat_unmatch = !!diff_auto_refresh_index; if (nongit)
At least builtin_diff_blobs() and builtin_diff_tree() won't need worktree, so NACK again. Anyway I'm not familiar with diff*. Junio should know these better. -- Duy