Re: [PATCH] Makefile: improve customization for supporting HP-UX

On Sat, Aug 23, 2008 at 10:26:01PM +0200, Miklos Vajna wrote:

On Sat, Aug 23, 2008 at 10:09:28PM +0200, Robert Schiele [off-list ref] wrote:

quoted

The systems I build on are:

1x HP-UX B.11.11 U 9000/785

This is the same version I'm using at the moment.

The NEEDS_LIBICONV is simple, the linker fails to find iconv symbols:

/usr/ccs/bin/ld: Unsatisfied symbols:
   libiconv (first referenced in libgit.a(utf8.o)) (code)
   libiconv_open (first referenced in libgit.a(utf8.o)) (code)
   libiconv_close (first referenced in libgit.a(utf8.o)) (code)
collect2: ld returned 1 exit status
gmake: *** [git] Error 1

Huh?  Where does the "lib" prefix come from on your system?  Do you have some
custom iconv header file in the way?  On my system I see:

[13] % nm /usr/lib/libc.2 | grep ^iconv
iconv               |   1255080|extern|entry  |
iconv               |   1255112|extern|code   |$CODE$
iconv_close         |   1254800|extern|entry  |
iconv_close         |   1254832|extern|code   |$CODE$
iconv_open          |   1255208|extern|entry  |
iconv_open          |   1255272|extern|code   |$CODE$
[14] % 

The SNPRINTF_RETURNS_BOGUS is not something you can notice compile-time,
but once you try to commit, you get:

$ git commit
fatal: your vsnprintf is broken

Ok, I see that as well.  Obviously nobody ever committed something on these
machines.  But since we use these machines mostly for building people need to
be able to checkout stuff only in most cases and this is most likely why it
passed unnoticed.

Thus I think the snprintf part of your patch makes sense but the iconv stuff
seems to be something flawed on your machine.

Robert

-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."