Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [bug] Segfault in git rev-list --first-parent --bisect

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:12

Junio C Hamano [off-list ref] writes:
"Avery Pennarun" [off-list ref] writes:
quoted
    $ git rev-list --first-parent --bisect 5109c91 ^d798a2bfe094
    Segmentation fault
Totally untested, usefulness fairly unknown.
The latter part of this statement needs a bit of explanation.  I do not
mean "--first-parent --bisect" is useless.  What I meant is that the
approach is only catering to --first-parent and not about non-standard way
to limit the list such as --since, --max-count, etc.

The current bisection algorithm only pays attention to the pathspec based
history simplification and bottom..top (aka "UNINTERESTING or not").  A
proper fix to handle these cases should work inside do_find_bisection(),
and count_interesting_parents() instead of hiding the parents away that
first_parent traversal did not touch, like the patch I sent out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help