Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Don't fail when an existing directory can't be created.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:12

David Kågedal [off-list ref] writes:
This makes it possible to install in a writable directory not owned by
the current user.
---
Sign-off?
quoted hunk
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 7a2130a..e6271d8 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -87,15 +87,15 @@ man7: $(DOC_MAN7)
 info: git.info gitman.info
 
 install: man
-	$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
-	$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
-	$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)
+	-$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
+	-$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
+	-$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)
Makes me wonder what happens if you failed to create the target
directory.  Is it deemed to be Ok because the later step of installing the
contents will fail anyway?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help