Re: [PATCH] Support "core.excludesfile = ~/.gitignore"

On Fri, Aug 22, 2008 at 18:58, Eric Raible [off-list ref] wrote:

Karl Chen <quarl <at> cs.berkeley.edu> writes:

quoted

+static char const *git_config_subst_userdir(char const *value) {
+     if (value[0] == '~' && value[1] == '/') {

Might you want to check that strlen(value) is at least 2?

No.

    swtich (strlen(value)) {
    case 0:
        /* value[0] == '\0' => value[0] != '~'
           value[1] will never be dereferenced, because of lazy && */
    case 1:
       /* value[0] != '\0'
          if (value[0] == '~')
              value[1] == '\0' => value[1] != '/' */
    default:
       /* ... */
    }

So no invalid memory dereferences.

Regards
Bert

- Eric

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html