Thread (11 messages) flat view 11 messages, 3 authors, 2016-06-15

Re: [PATCH] gitweb: ref markers link to named shortlogs

From: Giuseppe Bilotta <hidden>
Date: 2016-06-15 22:45:12

Possibly related (same subject, not in this thread)

On Fri, Aug 22, 2008 at 12:56 PM, Jakub Narebski [off-list ref] wrote:
This "couple of extra info" could be just '^{}' suffix.  So I don't
think it would be very complicated.

You could simply do not strip '^{}' suffix in git_get_references()
subroutine (so for example $refs->{$id} could be "tags/v1.6.0^{}",
and not simply "tags/v1.6.0" when $id is sha-1 of a _commit_ indirectly
referenced by v1.6.0, i.e. referenced by v1.6.0 _tag_), and strip
it and make use of it in format_ref_marker():

  if ($ref =~ s/\^\{\}$//) {
     # $ref is a tag
  } else {
     # $ref points directly to object
  }
I've actually changed the format of $refs, making the values into
arrays whose first value is the name and the other is the ^{} marker,
if present. Patch incoming.
P.S. I have re-added git mailing list to Cc:.
Oops, didn't realized I had forgotten it.

-- 
Giuseppe "Oblomov" Bilotta
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help