Re: Patch for NO_R_TO_GCC_LINKER
From: Matthieu Moy <hidden>
Date: 2016-06-15 22:45:09
"Giovanni Funchal" [off-list ref] writes:
Hi,
Hi Giovanni, glad to see you here ;-).
I'm proposing the patch below
Please, read Documentation/SubmittingPatches. I advise you to use git send-email to send your patches, this one has (gmail-related) whitespace damage. Read about Signed-Off-By too.
quoted hunk
@@ -226,7 +226,8 @@ INSTALL = install RPMBUILD = rpmbuild TCL_PATH = tclsh TCLTK_PATH = wish - +LD_RUNPATH_SWITCH = -Wl,-rpath, +
Whitespace damage: the - and the + are equal (I suppose you added a trailing whitespace, which you shouldn't have, and gmail stripped it).
- CURL_LIBCURL = -L$(CURLDIR)/$(lib) $(CC_LD_DYNPATH)$(CURLDIR)/$(lib) -lcurl + CURL_LIBCURL = -L$(CURLDIR)/$(lib) $(LD_RUNPATH_SWITCH)$(CURLDIR)/$(lib) -lcurl
Whitespace damage again.
+ AC_MSG_ERROR([no linker support for runtime path to dynamic libraries])
I don't think you should error out here: Git can still be compiled and can still run without this support (just use $LD_LIBRARY_PATH if needed). Keeping -R with a big warning would avoid having a regression in this case. Thanks, -- Matthieu