Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Makefile: add a target which will abort compilation with ancient shells

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:07

Brandon Casey [off-list ref] writes:
This adds a make target which can be used to try to execute certain shell
constructs which are required for compiling and running git.

This patch provides a test for the $() notation for command substition
which is used in the Makefile and extensively in the git scripts.

The make target is named in such a way as to be a hint to the user that
SHELL_PATH should be set to an appropriate shell. If the shell command
fails, the user should receive a message similar to the following:

make: *** [please_set_SHELL_PATH_to_a_more_modern_shell] Error 2

Signed-off-by: Brandon Casey <redacted>
---


Johannes Schindelin wrote:
quoted
Maybe we can even have some sanity check that tests if SHELL_PATH groks 
$()?
how about this?
Thanks, both.  I think this is cute and at the same time the right thing
to do ;-).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help